[S3 gateway] Return HTTP 409 (Conflict) when creating existing repo #2451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When copying to a new key, Rclone likes to try to create _all_ the S3 path down (it seems to think it's on a POSIXy filesystem so it `mkdir -p`s). A repository cannot be created by the gateway -- there is not enough info on the request -- but if we return a 409 (conflict) then Rclone continues and succeeds. There is no S3 gateway test, so tested manually using Rclone. Fixes #2447.
guy-har
approved these changes
Sep 5, 2021
pkg/gateway/operations/putbucket.go
Outdated
| func (controller *PutBucket) RequiredPermissions(_ *http.Request, repoID string) ([]permissions.Permission, error) { | ||
| return []permissions.Permission{ | ||
| { | ||
| Action: permissions.ReadRepositoryAction, |
There was a problem hiding this comment.
Yikes! You're right, S3 only accepts a single permission. So if I don't have CreateBucket permission on S3 and I try to create-bucket, I get 403 (AccessDenied) rather than 409 (BucketAlreadyOwnedByYou).
Switching to match. 🤷
|
Thanks! |
arielshaqed
deleted the
feature/2447-s3-gw-return-conflict-when-creating-existing-repo
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When copying to a new key, Rclone likes to try to create all the S3 path
down (it seems to think it's on a POSIXy filesystem so it
mkdir -ps). Arepository cannot be created by the gateway -- there is not enough info on
the request -- but if we return a 409 (conflict) then Rclone continues and
succeeds.
There is no S3 gateway test, so tested manually using Rclone.
Fixes #2447.