-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Entry content-type and aws s3 user metadata #2557
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat, thanks!
This is really good stuff; the only required changes are to the DDL update filenames, which AFAICT need to say "35" not "34" :-/
was late to the party, your PR took it ;) |
Co-authored-by: arielshaqed <ariels@treeverse.io>
Co-authored-by: arielshaqed <ariels@treeverse.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks!
Fix #2296
Fix #2429
S3 gateway multipart upload and put object can pass content-type header and it will be returned as part of the entry metadata and get object content-type. Object
head
request will report the content type as S3 does.OpenAPI's link object, stage, and upload accept content-type and store them as part of the object metadata.
Link physical object API call was updated to return the object stats in order to identify the content-type the server set in case we didn't pass any. We kept the same status code in order not to break backward compatibility.
lakectl upload was added a '--content-type' flag to support setting value while uploading the file.
x-amz-meta-*
.S3 gateway will pass the headers as the entry metadata fields and return all metadata with
x-amz-meta-
prefix as headers on getting object requestNo changes were introduced to our OpenAPI - didn't add new functionality to get/set the object metadata in this PR.
Future work will include testing this feature.