Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

block adapter remove dependency in s3 for multipart struct #2696

Merged
merged 4 commits into from
Nov 15, 2021
Merged

block adapter remove dependency in s3 for multipart struct #2696

merged 4 commits into from
Nov 15, 2021

Conversation

nopcoder
Copy link
Contributor

@nopcoder nopcoder commented Nov 11, 2021 •
edited
Loading

Waiting for #2684 - do not merge

@nopcoder nopcoder added the exclude-changelog PR description should not be included in next release changelog label Nov 11, 2021
@nopcoder nopcoder self-assigned this Nov 11, 2021
@nopcoder nopcoder marked this pull request as draft November 11, 2021 14:40
@nopcoder nopcoder force-pushed the chore/block-adapter-part branch from 184f824 to 9e548cf Compare November 14, 2021 16:44
@nopcoder nopcoder marked this pull request as ready for review November 14, 2021 21:59
@nopcoder nopcoder requested a review from arielshaqed November 14, 2021 22:00
arielshaqed
arielshaqed approved these changes Nov 15, 2021
View reviewed changes
Copy link
Contributor

@arielshaqed arielshaqed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great cleanup, thanks!

pkg/block/adapter.go Outdated Show resolved Hide resolved
pkg/block/s3/adapter.go Outdated Show resolved Hide resolved
@nopcoder
Copy link
Contributor Author

Transformed adapter to work with int instead of int64 for multipart

@nopcoder nopcoder requested a review from arielshaqed November 15, 2021 08:13
arielshaqed
arielshaqed reviewed Nov 15, 2021
View reviewed changes
Copy link
Contributor

@arielshaqed arielshaqed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, stillLGM...

@nopcoder nopcoder merged commit 6fc6fea into master Nov 15, 2021
@nopcoder nopcoder deleted the chore/block-adapter-part branch November 15, 2021 09:53
@nopcoder nopcoder linked an issue Nov 21, 2021 that may be closed by this pull request
Block adapter dependency on s3 aws #2694
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arielshaqed arielshaqed arielshaqed approved these changes

Assignees

@nopcoder nopcoder

Labels
area/block-adapter exclude-changelog PR description should not be included in next release changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Block adapter dependency on s3 aws
2 participants
@nopcoder @arielshaqed