Run unit tests on Windows #2740
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use windows-latest, this is *not* our primary platform. Mark experimental, for now failures are not blocking.
arielshaqed
added
the
include-changelog
Unfortunately there is no easy way to do this with a matrix rather than a list. Fortunately Windows should not stay experimental for that long.
arielshaqed
force-pushed
the
chore/2543-test-on-windows
branch
3 times, most recently
from
b42b6bd to
3c2b8c2
Compare
`go env` "helpfully" puts backslashes when running on Windows, even when it runs from `bash`. Fix that.
arielshaqed
force-pushed
the
chore/2543-test-on-windows
branch
from
3c2b8c2 to
eadc2e9
Compare
Otherwise on Windows it tries to bring Windows images -- which do not exist.
arielshaqed
force-pushed
the
chore/2543-test-on-windows
branch
from
ca5d772 to
66453a6
Compare
|
Diffs for how far I got: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use windows-latest, this is not our primary platform. Mark experimental,
for now failures are not blocking.