Improve dbt errors #2895
Merged
Improve dbt errors #2895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nopcoder
suggested changes
Jan 30, 2022
pkg/metastore/ms_client.go
Outdated
| } | ||
| return copyDBWithTransformLocation(ctx, fromClient, toClient, fromDB, toDB, transformLocation) | ||
| } | ||
|
|
||
| func copyDBWithTransformLocation(ctx context.Context, fromClient, toClient Client, fromDB string, toDB string, transformLocation func(location string) (string, error)) error { | ||
| schema, err := fromClient.GetDatabase(ctx, fromDB) | ||
| if err != nil { | ||
| return err | ||
| return fmt.Errorf("failed to get database on copy: %w", err) |
There was a problem hiding this comment.
would add the fromDB to the error
pkg/metastore/ms_client.go
Outdated
| return toClient.CreateDatabase(ctx, schema) | ||
| err = toClient.CreateDatabase(ctx, schema) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to create database with name %s and location %s :%w", schema.Name, schema.LocationURI, err) |
There was a problem hiding this comment.
- fix the spaces
- prefer to use '%s' to quote names/values
pkg/metastore/ms_client.go
Outdated
| return ReplaceBranchName(location, toBranch) | ||
| transformedLocation, err := ReplaceBranchName(location, toBranch) | ||
| if err != nil { | ||
| return "", fmt.Errorf("failed to replace branch name with location: %s and branch: %s : %w", location, toBranch, err) |
There was a problem hiding this comment.
optional:
Suggested change
| return "", fmt.Errorf("failed to replace branch name with location: %s and branch: %s : %w", location, toBranch, err) | |
| return "", fmt.Errorf("failed to replace branch name with location '%s' and branch '%s': %w", location, toBranch, err) |
pkg/metastore/ms_client.go
Outdated
| return ReplaceBranchName(location, toBranch) | ||
| transformedLocation, err := ReplaceBranchName(location, toBranch) | ||
| if err != nil { | ||
| return "", fmt.Errorf("failed to replace branch name with location: %s and branch: %s : %w", location, toBranch, err) |
There was a problem hiding this comment.
Suggested change
| return "", fmt.Errorf("failed to replace branch name with location: %s and branch: %s : %w", location, toBranch, err) | |
| return "", fmt.Errorf("failed to replace branch name with location '%s' and branch '%s': %w", location, toBranch, err) |
cmd/lakectl/cmd/dbt.go
Outdated
| @@ -168,7 +169,7 @@ func dbtDebug(projectRoot string) string { | |||
| dbtCmd.Dir = projectRoot | |||
| output, err := dbtCmd.Output() | |||
| if err != nil { | |||
| DieErr(err) | |||
| DieFmt("failed to run dbt debug with output:\n %s\n and error: %s", output, err) | |||
There was a problem hiding this comment.
Suggested change
| DieFmt("failed to run dbt debug with output:\n %s\n and error: %s", output, err) | |
| DieFmt("Failed to run dbt debug with output:\n%s\nError: %s", output, err) |
cmd/lakectl/cmd/dbt.go
Outdated
| @@ -146,7 +147,7 @@ func getDbtTables(projectRoot string) ([]model, error) { | |||
| dbtCmd.Dir = projectRoot | |||
| output, err := dbtCmd.Output() | |||
| if err != nil { | |||
| return nil, err | |||
| return nil, fmt.Errorf("failed to run dbt debug with output:\n %s\n and error: %s", output, err) | |||
There was a problem hiding this comment.
not sure about this one - it looks like an error that goes to the output not something that failed - it capture the output.
is that right?
There was a problem hiding this comment.
For some reason, when dbt debug returns an error, the information for the error is printed to the standard outpout
There was a problem hiding this comment.
Changed it, now, in case of error: the output is first printed as output and the error as error
guy-har
force-pushed
the
chore/improve-dbt-errors
branch
2 times, most recently
from
c6506e6 to
82def39
Compare
guy-har
force-pushed
the
chore/improve-dbt-errors
branch
from
82def39 to
daddbfb
Compare
guy-har
added
the
include-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.