Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add example message in lakectl repo create command #2900

Merged
merged 3 commits into from
Feb 2, 2022
Merged

Add example message in lakectl repo create command #2900

merged 3 commits into from
Feb 2, 2022

Conversation

mishraprafful
Copy link
Contributor

@mishraprafful mishraprafful commented Feb 1, 2022 •
edited
Loading

Related PR
Closes #2467

Changes

  • Added an example for lakectl repo create command

nopcoder
nopcoder requested changes Feb 1, 2022
View reviewed changes
Copy link
Contributor

@nopcoder nopcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution - minor comments for final approval. Please review the suggestions.

@mishraprafful
Copy link
Contributor Author

mishraprafful commented Feb 1, 2022 •
edited
Loading

@nopcoder Thanks for the suggestions, I have made the changes. Please consider for re-review.

nopcoder
nopcoder approved these changes Feb 1, 2022
View reviewed changes
Copy link
Contributor

@nopcoder nopcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank!

@nopcoder nopcoder added the include-changelog PR description should be included in next release changelog label Feb 1, 2022
@mishraprafful
Copy link
Contributor Author

mishraprafful commented Feb 1, 2022 •
edited
Loading

@nopcoder is the linter check failing an issue? I think the gofmt check passes though.

@nopcoder
Copy link
Contributor

nopcoder commented Feb 1, 2022

@mishraprafful very sorry - should have spot it in the review stage. The lakectl documentation is auto-generated, so running make gen-docs should update the required file and you can it to this PR.

@mishraprafful mishraprafful changed the title Add example message in lakectl repo create command Add example message in lakectl repo create command Feb 2, 2022
@nopcoder nopcoder merged commit cb4fcfa into treeverse:master Feb 2, 2022
@mishraprafful mishraprafful deleted the fix/lakectl-repo-create-usage-msg-2467 branch March 21, 2022 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nopcoder nopcoder nopcoder approved these changes

Assignees
No one assigned
Labels
include-changelog PR description should be included in next release changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve usage message in lakectl repo create
2 participants
@mishraprafful @nopcoder