Default storage namespace #2952
Conversation
johnnyaug
added
the
include-changelog
docs/reference/configuration.md
Outdated
| @@ -51,6 +51,9 @@ This reference uses `.` to denote the nesting of values. | |||
| * `auth.ldap.default_user_group` `(string : )` - Create all LDAP users in this group. Defaults to `Viewers`. | |||
| * `auth.ldap.user_filter` `(string : )` - Additional filter for users. | |||
| * `blockstore.type` `(one of ["local", "s3", "gs", "azure", "mem"] : required)`. Block adapter to use. This controls where the underlying data will be stored | |||
| * `blockstore.default_namespace_prefix` `(string : )` - Use this to help your users choose a storage namespace for their repositories. | |||
| When creating a repository from the UI, the storage namespace will be filled with this default value as a prefix. | |||
| The user may still change it to something else | |||
docs/reference/object-model.md
Outdated
| @@ -146,9 +146,13 @@ other user-defined merge strategies for handling conflicts are on the roadmap. | |||
| _Underlying storage_ is the area on some other object store that lakeFS uses to store object | |||
| contents and some of its metadata. We sometimes refer to underlying storage as _physical_. | |||
| The path used to store the contents of an object is then termed a _physical path_. The object | |||
| itself on underlying storage is never modified, except to remove it entirely during some | |||
| itself in the underlying storage is never modified, except to remove it entirely during some | |||
There was a problem hiding this comment.
I prefer the original statement.
|
|
||
| const [storageNamespaceValid, setStorageNamespaceValid] = useState(true); | ||
| const [storageNamespaceValid, setStorageNamespaceValid] = useState(defaultNamespacePrefix ? true : null); |
There was a problem hiding this comment.
Not sure the prefix itself is necessarily "valid"; don't we still need to check?
There was a problem hiding this comment.
Great catch! This is a leftover from a previous version
| @@ -52,7 +60,7 @@ export const RepositoryCreateForm = ({ config, onSubmit, onCancel, error = null, | |||
| if (!formValid) { | |||
| return; | |||
| } | |||
| onSubmit({ | |||
| onSubmit({ | |||
| <Form.Control type="text" autoFocus ref={repoNameField} onChange={checkRepoValidity}/> | ||
| {!repoValid && | ||
| <Form.Control type="text" autoFocus ref={repoNameField} onChange={onRepoNameChange}/> | ||
| {repoValid === false && |
There was a problem hiding this comment.
| {repoValid === false && | |
| {!repoValid && |
(think I prefer this.)
There was a problem hiding this comment.
This is actually fixing a bug where the "Create repository" button becomes enabled even if you don't fill the storage namespace.
@talSofer, yes. Repositories should be in separate namespaces. We maybe not stress this enough in our docs, but some settings (like GC, branch protection) will override each other if repositories are in the same namespace. |
I see, can you open an issue to improve docs and maybe force this by code + migrate environments that are structured differently? |
Added a new configuration
blockstore.default_namespace_prefix.When specified, the storage namespace field in the UI will be auto-filled.
The specified value will be the prefix, and the repository name will be added to it.
Extra