-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/2935 lakectl bug on not found html #2966
Merged
Merged
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
855e9ce
avoiding redirect automatically
idanovo 704cacd
Changed all CLI commands to fail on unexpected status code returned
idanovo 3066a9c
Format fixes
idanovo 574c765
Fixed expected status for git repository create with bare flag
idanovo f7bb6ea
Fixed Lakectl doctor commmand due to changes in changes on redirect r…
idanovo 3160b53
Reformated import order
idanovo 08582c2
Fixed expected status for branch protected add example text
idanovo 360d462
Reverted unrelated changes to current PR
idanovo 3513f29
Reverted changes
idanovo 688de92
Fixed imports order and responses naming
idanovo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for being unclear: I really liked this change, it's part of the res -> resp fix. It caused an issue with this PR, so I think we have no choice but to make this unrelated change here. (Technically we could have a preview PR that just fixed this, and then your PR. Too much effort for too little gain probably.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure how we can fix this in this case. We are trying to assign
resp
in l.84 with a different type. Maybe changeres
here to be_resp
?