Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

additional tests to FindMergeBase #2991

Merged
merged 1 commit into from
Mar 1, 2022

Conversation

itaidavid
Copy link
Contributor

@itaidavid itaidavid commented Feb 28, 2022

Following #2968 - some additional tests to demonstrate and protect the fix to FindMergeBase

@itaidavid itaidavid added the exclude-changelog PR description should not be included in next release changelog label Feb 28, 2022
Copy link
Contributor

@johnnyaug johnnyaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great tests! Love it

// \ /\ /\ /
// l9 \ / r9
// \ / \ /
// LEFT RIGHT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is some A-level ASCII art

// \ /\ /\ /
// l4 \ / r4
// /\ / \ /\
// / l5 r6 \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing l6 and r5 in the drawing

@itaidavid itaidavid merged commit a285ab4 into master Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude-changelog PR description should not be included in next release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants