Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking Change: Update commit ref to commit URI for lakectl tag create command #3017

Merged
merged 2 commits into from
Mar 9, 2022
Merged

Breaking Change: Update commit ref to commit URI for lakectl tag create command #3017

merged 2 commits into from
Mar 9, 2022

Conversation

mishraprafful
Copy link
Contributor

Related Issues/PRs
Closes #2409

Changes Introduced

  • Update commit Ref to Commit URI for lakectl tag create command.

johnnyaug
johnnyaug approved these changes Mar 8, 2022
View reviewed changes
Copy link
Contributor

@johnnyaug johnnyaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome fix! Thank you @mishraprafful

@johnnyaug johnnyaug added the include-changelog PR description should be included in next release changelog label Mar 8, 2022
@itaiad200 itaiad200 changed the title Update commit ref to commit URI for Lakectl tag create command Breaking Change: Update commit ref to commit URI for Lakectl tag create command Mar 8, 2022
@itaiad200
Copy link
Contributor

Changed the PR title to reflect this is a breaking change.

@mishraprafful
Copy link
Contributor Author

@johnnyaug @itaiad200 I fixed the linting issue, not sure about the failing tests though, it seems to be from lakefs/pkg/gateway. If you could point me to what might be the issue I can add a fix.

@itaiad200
Copy link
Contributor

It appears that Github Actions will only run it for the first time for external forks PR, when an approval was granted. Source.
Merging it as the same tests passed on the first try, thanks @mishraprafful !

@itaiad200 itaiad200 changed the title Breaking Change: Update commit ref to commit URI for Lakectl tag create command Breaking Change: Update commit ref to commit URI for lakectl tag create command Mar 9, 2022
@itaiad200 itaiad200 merged commit 0bc0b0c into treeverse:master Mar 9, 2022
@mishraprafful mishraprafful deleted the fix/2409-create-tag-commit-ref-syntax branch March 9, 2022 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itaiad200 itaiad200 itaiad200 approved these changes

@johnnyaug johnnyaug johnnyaug approved these changes

Assignees
No one assigned
Labels
contributor include-changelog PR description should be included in next release changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lakectl | tags command are not clear
3 participants
@mishraprafful @itaiad200 @johnnyaug