Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2550] Dont show GetStarted for empty commit #3041

Merged
merged 2 commits into from
Mar 20, 2022

Conversation

tshradheya
Copy link
Contributor

Fixes #2550

Only showing the GetStarted Page when the user is on main branch and branch is empty.

Selecting refs would show results even if empty

@tshradheya
Copy link
Contributor Author

@talSofer is there a way for me to update the label to pass all checks?

@nopcoder nopcoder added the include-changelog PR description should be included in next release changelog label Mar 17, 2022
@nopcoder
Copy link
Contributor

@tshradheya thanks for the contribution, I've updated the required label and added a small comment to your change.

@tshradheya tshradheya requested a review from nopcoder March 19, 2022 08:52
Copy link
Contributor

@nopcoder nopcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nopcoder nopcoder merged commit df95d66 into treeverse:master Mar 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor include-changelog PR description should be included in next release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get-started is shown for an empty past commit
4 participants