Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emailer config smpt_port with additional ssl and local_name #3272

Merged
merged 1 commit into from
Apr 28, 2022
Merged

Emailer config smpt_port with additional ssl and local_name #3272

merged 1 commit into from
Apr 28, 2022

Conversation

nopcoder
Copy link
Contributor

Address the following for our emailer configuration:

  1. Update configuration from port to smtp_port to align with smtp_host.
  2. Add use_ssl to configure mailer to use ssl not just on default ssl port.
  3. Configure local_name - how we identify the domain with smtp server.

@nopcoder nopcoder requested review from guy-har and shimi9276 April 28, 2022 08:28
@nopcoder nopcoder self-assigned this Apr 28, 2022
guy-har
guy-har approved these changes Apr 28, 2022
View reviewed changes
Copy link
Contributor

@guy-har guy-har left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks!

@nopcoder nopcoder added the exclude-changelog PR description should not be included in next release changelog label Apr 28, 2022
shimi9276
shimi9276 approved these changes Apr 28, 2022
View reviewed changes
Copy link
Contributor

@shimi9276 shimi9276 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nopcoder nopcoder merged commit 4941971 into master Apr 28, 2022
@nopcoder nopcoder deleted the chore/email-config branch April 28, 2022 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shimi9276 shimi9276 shimi9276 approved these changes

@guy-har guy-har guy-har approved these changes

Assignees

@nopcoder nopcoder

Labels
exclude-changelog PR description should not be included in next release changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nopcoder @guy-har @shimi9276