Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: fix create repository focus on name #3342

Merged
merged 1 commit into from
May 11, 2022
Merged

UI: fix create repository focus on name #3342

merged 1 commit into from
May 11, 2022

Conversation

nopcoder
Copy link
Contributor

@nopcoder nopcoder commented May 10, 2022 •
edited
Loading

Current behaviour

While clicking Create Reposioty button.
A modal dialog with repository information will popup.

  1. The focus is not set on the repository name, so trying to write something will do nothing.
  2. Using tab switching focus will go over the dialog inputs - one of the input is the information link (i).

New behaviour

In order to have better input experience:

  1. Focus is set to the repository name when the dialog apper.
  2. Using tab to switch focus will not go over the hyperlink of the information icon.

Fix #3343

@nopcoder
ui: fix create repo focus on name
539a705 
additionaliy the info icon should skip tab index
@nopcoder nopcoder added area/UI Improvements or additions to UI include-changelog PR description should be included in next release changelog labels May 10, 2022
@nopcoder nopcoder requested review from N-o-Z and itaidavid May 10, 2022 21:13
@nopcoder nopcoder self-assigned this May 10, 2022
@nopcoder nopcoder changed the title ui: fix create repo focus on name UI: fix create repository focus on name May 10, 2022
N-o-Z
N-o-Z requested changes May 11, 2022
View reviewed changes
Copy link
Member

@N-o-Z N-o-Z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nopcoder Since I'm not so familiar with the UI, I didn't quite understand what exactly the issue is. I tried to compare the form from the playground with running a local server but I didn't see any difference.
Can you please add some explanation to the description of the PR? Thanks!

@nopcoder
Copy link
Contributor Author

@N-o-Z sure, update description soon

@nopcoder nopcoder requested a review from N-o-Z May 11, 2022 06:37
N-o-Z
N-o-Z approved these changes May 11, 2022
View reviewed changes
Copy link
Member

@N-o-Z N-o-Z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@nopcoder nopcoder merged commit 2400b40 into master May 11, 2022
@nopcoder nopcoder deleted the fix/ui-create-repo-focus branch May 11, 2022 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@N-o-Z N-o-Z N-o-Z approved these changes

@itaidavid itaidavid Awaiting requested review from itaidavid

Assignees

@nopcoder nopcoder

Labels
area/UI Improvements or additions to UI include-changelog PR description should be included in next release changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI create repository focus
2 participants
@nopcoder @N-o-Z