LAKECTL_INTERACTIVE env can control lakeCTL on/off terminal output #3358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nopcoder
added
the
exclude-changelog
nopcoder
force-pushed
the
fix/lakectl-interactive
branch
from
e056322 to
6e7d59b
Compare
|
@nopcoder do you think a test that checks the output of a simple command with and without the flag would help us here? |
The plan is to use this feature in all the tests that verify the lakectl output in the terminal format. |
idanovo
approved these changes
May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
LAKECTL_INTERACTIVEenvironment variable boolean (already supported), we can force lakectl terminal (interactive on) or no terminal (interactive off).By setting a value, it will override the default behaviour where we try to identify if the terminal is currently attached to our standard output.
Fix #3026