Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create branch name validation message #3374

Merged
merged 2 commits into from
May 22, 2022
+3 −0
Merged

create branch name validation message #3374

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53f42a4
create branch name validation message
eden-ohana May 17, 2022
6449972
return validation message only on create branch
eden-ohana May 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pkg/catalog/catalog.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,6 +386,9 @@ func (c *Catalog) CreateBranch(ctx context.Context, repository string, branch st
{Name: "branch", Value: branchID, Fn: graveler.ValidateBranchID},
{Name: "ref", Value: sourceRef, Fn: graveler.ValidateRef},
}); err != nil {
if errors.Is(err, graveler.ErrInvalidBranchID) {
return nil, fmt.Errorf("%w: branch id must consist of letters, digits, underscores and dashes, and cannot start with a dash", err)
}
return nil, err
}
newBranch, err := c.Store.CreateBranch(ctx, repositoryID, branchID, sourceRef)
Expand Down