Delete objects as part of Graveler #4205
Conversation
Optimize multiple object delete operation as part of gateway and openapi, by adding DeleteBatch operation that will perform the multiple delete as part of Graveler.
nopcoder
added
the
include-changelog
pkg/graveler/graveler.go
Outdated
| @@ -2775,3 +2806,20 @@ func NewRepoInstanceID() string { | |||
| tm := time.Now().UTC() | |||
| return xid.NewWithTime(tm).String() | |||
| } | |||
|
|
|||
| // NewMapDeleteErrors map multi error holding DeleteError to a map of object key -> error | |||
| func NewMapDeleteErrors(err error) map[string]error { | |||
There was a problem hiding this comment.
Can we move it to the errors.go file?
Co-authored-by: itaiad200 <itaiad200@gmail.com>
| delErr := c.Catalog.DeleteEntries(ctx, repository, branch, pathsToDelete) | ||
| delErrs := graveler.NewMapDeleteErrors(delErr) | ||
| for _, objectPath := range pathsToDelete { |
There was a problem hiding this comment.
Why are you iterating the pathsToDelete, rather than the actual errors?
What should happen if all deletions in batch are successful?
There was a problem hiding this comment.
At the first part of the function we verified authorization - each file that we do not have access we added an error or added to 'pathsToDelete'.
The list 'pathsToDelete' represents all the files we need to delete (errors will include why we can't delete the rest).
Part of the protocol we need to report (optional - quiet flag) which files we deleted or not.
So going over the files it is to either report a successful delete or the specific/general error why it is not.
Optimize multiple object delete operation as part of gateway and open-api, by adding DeleteBatch operation that will perform the multiple delete as part of Graveler.
Notes:
Fix #4203