Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UI repository settings label width #4300

Merged
merged 4 commits into from
Oct 3, 2022
Merged

Fix UI repository settings label width #4300

merged 4 commits into from
Oct 3, 2022

Conversation

nopcoder
Copy link
Contributor

@nopcoder nopcoder commented Oct 2, 2022

Fix #4284

  • remove unused code
  • fix code style
  • fix package json deps order

@nopcoder nopcoder added area/UI Improvements or additions to UI include-changelog PR description should be included in next release changelog labels Oct 2, 2022
@nopcoder nopcoder requested a review from eladlachmi October 2, 2022 21:46
@nopcoder nopcoder self-assigned this Oct 2, 2022
eladlachmi
eladlachmi approved these changes Oct 3, 2022
View reviewed changes
Copy link
Contributor

@eladlachmi eladlachmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@nopcoder nopcoder merged commit dde1cd9 into master Oct 3, 2022
@nopcoder nopcoder deleted the fix/ui-repo-settings branch October 3, 2022 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eladlachmi eladlachmi eladlachmi approved these changes

Assignees

@nopcoder nopcoder

Labels
area/UI Improvements or additions to UI include-changelog PR description should be included in next release changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI lakeFS settings page "Storage namespace" label overrun by input
2 participants
@nopcoder @eladlachmi