Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lakectl check bad response #4331

Merged
merged 2 commits into from
Oct 11, 2022
Merged

lakectl check bad response #4331

merged 2 commits into from
Oct 11, 2022

Conversation

nopcoder
Copy link
Contributor

@nopcoder nopcoder commented Oct 7, 2022 •
edited
Loading

In case where the server returns the right status code, but we fail to parse the response or identify the right content type. The request should fail with an error message.

  • Create repository bare response code fix (based on a different PR will merge after)
  • Create repository (with and without bare) skip get repository - create returns all the required data.

Fix #3696

@nopcoder nopcoder self-assigned this Oct 7, 2022
@nopcoder nopcoder added the include-changelog PR description should be included in next release changelog label Oct 8, 2022
@nopcoder nopcoder marked this pull request as ready for review October 8, 2022 09:15
@nopcoder nopcoder requested a review from N-o-Z October 11, 2022 05:33
@nopcoder
lakectl check bad response
c401ff6 
In case where the server returns the right status code, but we fail to
parse the response or identify the right content type. The request
should fail with an error message.
@nopcoder nopcoder force-pushed the fix/check-lakectl-response branch from 994990f to c401ff6 Compare October 11, 2022 09:47
eden-ohana
eden-ohana approved these changes Oct 11, 2022
View reviewed changes
Copy link
Contributor

@eden-ohana eden-ohana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nopcoder nopcoder enabled auto-merge (squash) October 11, 2022 12:28
@nopcoder nopcoder merged commit 602ff4d into master Oct 11, 2022
@nopcoder nopcoder deleted the fix/check-lakectl-response branch May 22, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eden-ohana eden-ohana eden-ohana approved these changes

@itaiad200 itaiad200 Awaiting requested review from itaiad200

@N-o-Z N-o-Z Awaiting requested review from N-o-Z

Assignees

@nopcoder nopcoder

Labels
include-changelog PR description should be included in next release changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lakectl repo list segfaults on expired playground account
2 participants
@nopcoder @eden-ohana