[API breaking change] add prefix change indicator #4403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eden-ohana
added
the
include-changelog
itaiad200
requested changes
Oct 20, 2022
There was a problem hiding this comment.
Thanks! Some questions & comments:
- Does the UI support it out of the box? I think we should at least introduce new colouring to changed prefixes to differentiate them from changed objects.
- We need some testing (new or modify existing) that validates the new behaviour.
- I think we should make the documentation changes in this PR, Docs: Explain metadata operations costs and affects better #4070 is a whole different issue (although it involves docs too..).
johnnyaug
reviewed
Oct 23, 2022
pkg/api/transform.go
Outdated
| @@ -14,6 +14,8 @@ func transformDifferenceTypeToString(d catalog.DifferenceType) string { | |||
| return "changed" | |||
| case catalog.DifferenceTypeConflict: | |||
| return "conflict" | |||
| case catalog.DifferenceTypePrefixChanged: | |||
| return "prefix changed" | |||
There was a problem hiding this comment.
Suggested change
| return "prefix changed" | |
| return "changes under prefix" |
|
@itaiad200 - please, no more colors in the diff screen. The UI shows a folder icon, indicating that this is a prefix and not a single object. I would argue that this enough. |
|
|
|
|
|
itaiad200
approved these changes
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4068
documentation will be added as part of #4070
I'm open to better suggestions for a name to indicate prefix change