-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for graveler *and* catalog ErrNotFound #4436
Conversation
Tested manually:
(also tested with a bad branch and a bad repo). Will add separately unit tests for getobject and headobject. |
d0fc8c1
to
2c9ef54
Compare
esti/s3_gateway_test.go
Outdated
t.Run("Doesn't exist", func(t *testing.T) { | ||
_, err := client.GetObject(ctx, repo, goodPath, minio.GetObjectOptions{}) | ||
if err != nil { | ||
t.Errorf("client.GetObject(%s, %s): %s", repo, goodPath, err) | ||
} | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this test check for the correct response if the path doesn't exist?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does, now :-)
2c9ef54
to
7c8e5c8
Compare
7c8e5c8
to
946cf7b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick fix!
Thanks! |
Fixes #4427.
Opened #4435 to refactor to help protect against similar recurrences.