Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: remove unused diff_type from diffRefs operation #4462

Merged
merged 2 commits into from
Oct 26, 2022
Merged

Conversation

nopcoder
Copy link
Contributor

The current code uses 'type' to control which diff type we like to perform.

Fix #4461

The current code uses 'type' to control which diff type we like to
perform.
@nopcoder nopcoder added the area/API Improvements or additions to the API label Oct 25, 2022
@nopcoder nopcoder self-assigned this Oct 25, 2022
@nopcoder nopcoder added the include-changelog PR description should be included in next release changelog label Oct 25, 2022
@nopcoder nopcoder marked this pull request as ready for review October 25, 2022 14:25
@nopcoder nopcoder requested a review from itaiad200 October 25, 2022 14:25
Copy link
Contributor

@itaiad200 itaiad200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nopcoder nopcoder merged commit ef2f1c7 into master Oct 26, 2022
@nopcoder nopcoder deleted the fix/diff-type branch October 26, 2022 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/API Improvements or additions to the API include-changelog PR description should be included in next release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

diffRefs API has type, diff_type params but uses only type
2 participants