-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lakectl import #4558
lakectl import #4558
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, code LGTM! Mostly minor comments.
Please add documentation to the import section.
@@ -2168,6 +2168,29 @@ lakectl help [command] [flags] | |||
|
|||
|
|||
|
|||
### lakectl import |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also add documentation to https://docs.lakefs.io/setup/import.html#import-data-into-lakefs ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@itaiad200 we want to remove the ingest from lakectl in order to have one way to do it?
Currently the "zero copy" import described there is based on the UI capability and the lakectl ingest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so, no. The ingest
is leaner and more flexible as it creates uncommitted entries instead of entire commits.
|
||
var importCmd = &cobra.Command{ | ||
Use: "import --from <object store URI> --to <lakeFS path URI> [--merge]", | ||
Short: "Import data from external source to an imported branch (with optional merge)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if "external source" is indicative enough. We can only import from object store paths that the lakeFS server has access to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Took it from the docs "The lakectl command supports ingesting objects from an external source. This is done by listing the source bucket (and optional prefix), and creating pointers to the returned objects in lakeFS."
Co-authored-by: itaiad200 <itaiad200@gmail.com>
Co-authored-by: itaiad200 <itaiad200@gmail.com>
Co-authored-by: itaiad200 <itaiad200@gmail.com>
Close #4450