Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix large file and png preview issues #4569

Merged
merged 3 commits into from
Nov 8, 2022
Merged

Fix large file and png preview issues #4569

merged 3 commits into from
Nov 8, 2022

Conversation

eladlachmi
Copy link
Contributor

Resolves #4556
Resolves #4555

@eladlachmi eladlachmi added the include-changelog PR description should be included in next release changelog label Nov 7, 2022
@eladlachmi
Copy link
Contributor Author

This PR also adds viewer support for PNG and JPEG files. FYI

guy-har
guy-har approved these changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@guy-har guy-har left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ortz
ortz approved these changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@ortz ortz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@eladlachmi eladlachmi merged commit 20f2c15 into master Nov 8, 2022
@eladlachmi eladlachmi deleted the fix/4556-large-files-crash-browser branch November 8, 2022 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guy-har guy-har guy-har approved these changes

@ortz ortz ortz approved these changes

@johnnyaug johnnyaug Awaiting requested review from johnnyaug

Assignees
No one assigned
Labels
include-changelog PR description should be included in next release changelog
Projects
None yet
Milestone
No milestone
3 participants
@eladlachmi @ortz @guy-har