Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change API event_type from enum to string #4613

Merged
merged 1 commit into from
Nov 20, 2022
Merged

Change API event_type from enum to string #4613

merged 1 commit into from
Nov 20, 2022

Conversation

itaiad200
Copy link
Contributor

closes #4608

@itaiad200 itaiad200 added bug Something isn't working team/versioning-engine Team versioning engine labels Nov 20, 2022
@N-o-Z
Copy link
Member

N-o-Z commented Nov 20, 2022

@itaiad200 Did you test the fix on a previously unsupported hook?

@itaiad200 itaiad200 added the include-changelog PR description should be included in next release changelog label Nov 20, 2022
@itaiad200
Copy link
Contributor Author

@itaiad200 Did you test the fix on a previously unsupported hook?

Testing it as we speak

@itaiad200
Copy link
Contributor Author

@itaiad200 Did you test the fix on a previously unsupported hook?

Testing it as we speak

Tested locally with post-commit and it worked as expected.

N-o-Z
N-o-Z approved these changes Nov 20, 2022
View reviewed changes
Copy link
Member

@N-o-Z N-o-Z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@itaiad200 itaiad200 merged commit 010592b into master Nov 20, 2022
@itaiad200 itaiad200 deleted the 4605-api-event-type branch November 20, 2022 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@N-o-Z N-o-Z N-o-Z approved these changes

@nopcoder nopcoder Awaiting requested review from nopcoder

@eden-ohana eden-ohana Awaiting requested review from eden-ohana

Assignees
No one assigned
Labels
bug Something isn't working include-changelog PR description should be included in next release changelog team/versioning-engine Team versioning engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API's actions event_type is too narrow
2 participants
@itaiad200 @N-o-Z