-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore request_id to Graveler logs #4616
Conversation
Also add request_id to _some_ logs to actions. Fixes #4566, and helps push
Tested by running locally manually. I can now see:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, require a minor fix to the code documentation.
pkg/graveler/graveler.go
Outdated
@@ -859,7 +859,9 @@ type KVGraveler struct { | |||
StagingManager StagingManager | |||
protectedBranchesManager ProtectedBranchesManager | |||
garbageCollectionManager GarbageCollectionManager | |||
log logging.Logger | |||
// loggerBase enriched with context to be used for logging. It |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to fix to 'logger' or 'log' to match the field name
Fixed, thanks! Pulling once tests green. |
Also add request_id to some logs to actions. Fixes #4566, and helps push
#2682 towards the finish line.