Add byte range support to OpenAPI (server, spec and generated clients) #4623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ozkatz
added
area/API
ozkatz
changed the title
ozkatz
added
include-changelog
|
closes #4624 |
nopcoder
suggested changes
Nov 21, 2022
nopcoder
changed the title
nopcoder
approved these changes
Nov 21, 2022
arielshaqed
approved these changes
Nov 21, 2022
Comment on lines
+2710
to
+2727
| headers: | ||
| Content-Length: | ||
| schema: | ||
| type: integer | ||
| format: int64 | ||
| Content-Range: | ||
| schema: | ||
| type: string | ||
| pattern: '^bytes=((\d*-\d*,? ?)+)$' | ||
| Last-Modified: | ||
| schema: | ||
| type: string | ||
| ETag: | ||
| schema: | ||
| type: string | ||
| Content-Disposition: | ||
| schema: | ||
| type: string |
There was a problem hiding this comment.
If we can easily share the schemata for the parts shared with 200, it would be great. But not worth making a great effort for that.
There was a problem hiding this comment.
Not really sure how to do that.. I can try in a different PR (but not guaranteeing anything :))
pkg/api/controller_test.go
Outdated
| t.Fatal(err) | ||
| } | ||
| if resp.HTTPResponse.StatusCode != http.StatusPartialContent { | ||
| t.Fatalf("GetObject() status code %d, expected %d", resp.HTTPResponse.StatusCode, http.StatusPartialContent) |
There was a problem hiding this comment.
If we can make this and most or all following errors t.Errorf, the added error messages might greatly aid debugging if/when this test fails.
There was a problem hiding this comment.
Agreed. Changed this and adjacent get_object tests to avoid scope creep for this PR.. we might want to somehow lint for this..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: trying to read parquet footer from Pandas using the Python SDK, I discovered I can't read the Parquet footer since the API does not support byte ranges