-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow adding hooks without depending on an external service #4779
Conversation
General note about the mechanicam - a lot of systems uses Lua as the engine to drive the hooks - so instead of having a set of yaml files trigger set of lua files, like in neovim you have init.lua and all the reset are functions and events you register to triggered by the system. By leverage the lua runtime and registering the right functions the user can build a complete DAG or a system using Lua - have single or multiple steps in parallel or in serial. No more compile time to register new hooks - you can have the current hooks system implemented in lua. (hope I was clear on what I was trying to suggest here) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excited experiment
It may look like many lines of code, but this is mostly due to vendoring (and internally forking) shopify/goluago.
A detailed proposal, including user story is under design/open/zero-deployment-hooks.md