Perform fewer API calls for exists #4797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the "does not exist" path faster: with this change it typically takes 1 listObjects() API call instead of 1 statObject and 2 listObjects. This is surprisingly *common*. The trivial "exists" path now requires 1 listObject instead of 1 statObject call, which is more expensive.
arielshaqed
added
performance
include-changelog
Jonathan-Rosenberg
approved these changes
Dec 19, 2022
|
Thanks! Pulling... |
arielshaqed
deleted the
bugfix/4676-lakefsfs-reduce-api-calls-for-exists
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the "does not exist" path faster: with this change it typically takes 1
listObjects() API call instead of 1 statObject and 2 listObjects. This is
surprisingly common.
However... The trivial "exists" path now requires 1 listObject instead of 1
statObject call. This is slightly more expensive, so this change will help
a lot more once we finish #4734. (I did test it as faster with #4792, but then
we deprioritized that work in ecosystem team.)