API delete will not return object not found

[nopcoder]

Change in API delete object

The delete object(s) APIs will no longer return "not found" status code when object doesn't exists (similar to S3 behaviour).

The API will not return NotFound errors in the following cases:

• when tombstone found on stage
• when object not found on branch commit

Fix #4798

[arielshaqed]

Thanks!
This looks great, but I would like it to go much further! I want us to remove the 404 response entirely. Currently swagger.yml makes me think that I could synchronize multiple workers on 200-vs-404s, but in fact this is not true! 404 is not programmatically usable in the API.

[nopcoder]

Thanks! This looks great, but I would like it to go much further! I want us to remove the 404 response entirely. Currently swagger.yml makes me think that I could synchronize multiple workers on 200-vs-404s, but in fact this is not true! 404 is not programmatically usable in the API.

We require 404 for repository and branch not found

[arielshaqed]

Thanks!

I think we can try to improve the API documentation, and made some suggestions.

In any case it's a really useful change: as someone coding against it, an API that precisely describes what it does is really important to me.

[arielshaqed]

Suggested change

	summary: delete object. Missing objects will not return a NotFound error.
	summary: delete object.

I believe that this belongs on the descriptions of 204 and of 404, and in a positive not a negative.

        404:
          description: Repository or branch do not exist.
          $ref: "#/components/responses/NotFound"

(The same for deleteObjects, of course!)

[nopcoder]

Tried this one first. The description is part of the definition. Set it also on the status code - the code generators just ignore it.

[arielshaqed]

Suggested change

	description: object deleted successfully
	description: Success: Now there is no object at key. Also returned if the object did not exist in the first place.