fix: loading of duckdb every query #4903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ozkatz
added
bug
eladlachmi
suggested changes
Jan 2, 2023
| const data = results.toArray() | ||
| setData(data) | ||
| setError(null) | ||
|
|
||
| }).catch(e => { |
There was a problem hiding this comment.
You're mixing paradigms. .catch is Promise syntax and async-await is a different approach. If you're using async-await, you should use plain old try-catch-finally. That's the idea of async-await - writing sync-style code, and abstracting away all of the Promise handling, continuation, error handling, etc.
| let content; | ||
| let button = ( |
There was a problem hiding this comment.
IMO something along these lines would be cleaner and more readable.
Suggested change
| let button = ( | |
| const button = ( | |
| <Button type="submit" variant="success" disabled={loading}> | |
| <DatabaseIcon /> {" "} | |
| { loading ? "Executing..." : "Execute" } | |
| </Button> | |
| ); |
| e.preventDefault() | ||
| setShouldSubmit(!shouldSubmit) | ||
| }}> | ||
| <Form onSubmit={handleSubmit}> |
| <Form.Control as="textarea" className="object-viewer-sql-input" rows={5} value={query} spellCheck={false} onChange={e => { | ||
| setQuery(e.target.value) | ||
| }} /> | ||
| <Form.Control as="textarea" className="object-viewer-sql-input" rows={5} defaultValue={initialQuery} spellCheck={false} ref={sql} /> |
There was a problem hiding this comment.
Not sure if it's something you want, but maybe add autocomplete={false}, so the native browser autocomplete thing doesn't pop up (unless you want. that, of course)
| </Form> | ||
| <div className={"mt-3 object-viewer-sql-results"}> | ||
| <div className={"mt-3"}> |
There was a problem hiding this comment.
Not sure there's a need for the curly braces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the duckDB wasm package being downloaded on every query (as well as a few minor tweaks to the UX of running said queries)