Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor lakefs_export script output #4904

Merged
merged 3 commits into from
Jan 1, 2023
Merged

Refactor lakefs_export script output #4904

merged 3 commits into from
Jan 1, 2023

Conversation

arielshaqed
Copy link
Contributor

@arielshaqed arielshaqed commented Dec 29, 2022 •
edited
Loading

  • Change environment variables used to configure lakefs_export. We now use the same environment variables as elsewhere:
    • For accessing S3: AWS_ACCESS_KEY_ID, AWS_SECRET_ACCESS_KEY
    • For accessing lakeFS: LAKEFS_ACCESS_KEY_ID, LAKEFS_SECRET_ACCESS_KEY
  • lakefs_export now avoids most temporary files
  • Don't read entire "rclone check" output into memory
  • Detect "rclone check" success/failure directly rather than via error
    output, and correctly detects more failures.

This is part of #4841 but obviously not a fix for it.

@github-actions
Copy link

No linked issues found. Please add the corresponding issues in the pull request description.
Use GitHub automation to close the issue when a PR is merged

@arielshaqed arielshaqed added area/gateway Changes to the gateway exclude-changelog PR description should not be included in next release changelog minor-change Used for PRs that don't require issue attached tech-debt labels Dec 29, 2022
@arielshaqed
Refactor lakefs_export script output
a6e30bf 
* Rename environment variables to be in line with other tooling
  - AWS_ACCESS_KEY_ID, AWS_SECRET_ACCESS_KEY
  - LAKEFS_ACCESS_KEY_ID, LAKEFS_SECRET_ACCESS_KEY
* Avoid temporary files
* Don't read entire "rclone check" output into memory
* Detect "rclone check" success/failure directly rather than via error
  output

This is part of #4841 but obviously not a fix for it.
@arielshaqed arielshaqed force-pushed the chore/clean-up-output-lakefs-export branch from cf00e84 to 5ebaede Compare December 29, 2022 13:48
@arielshaqed arielshaqed force-pushed the chore/clean-up-output-lakefs-export branch from 5ebaede to 97e4798 Compare December 29, 2022 13:56
lynnro314
lynnro314 approved these changes Dec 29, 2022
View reviewed changes
Copy link
Contributor

@lynnro314 lynnro314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@arielshaqed
Copy link
Contributor Author

Thanks, @lynnro314 !

Updated docs with changed script envariables and will pull once tests green.

@arielshaqed arielshaqed added include-changelog PR description should be included in next release changelog and removed exclude-changelog PR description should not be included in next release changelog labels Jan 1, 2023
@arielshaqed arielshaqed mentioned this pull request Jan 1, 2023
Closed
@arielshaqed arielshaqed merged commit 73415ae into master Jan 1, 2023
@arielshaqed arielshaqed deleted the chore/clean-up-output-lakefs-export branch January 1, 2023 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lynnro314 lynnro314 lynnro314 approved these changes

Assignees
No one assigned
Labels
area/gateway Changes to the gateway include-changelog PR description should be included in next release changelog minor-change Used for PRs that don't require issue attached tech-debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arielshaqed @lynnro314