Report all errors as messages not as Exceptions #4914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves the UX and makes thing more scriptable and more UN*X-like. Tested by manually running these failing commands: ```sh ❯ ./lakefs_export.py --branch asdf --commit_id sdf abc def Cannot set both branch and commit ❯ ./lakefs_export.py abc def Must set one of branch, commit ❯ ./lakefs_export.py --prev_commit_id asdf --commit_id sdf abc def Cannot export diff between two commits. ``` Fixes #4912.
johnnyaug
reviewed
Jan 1, 2023
Comment on lines
86
to
88
| error("Cannot set both branch and commit_id") | ||
| else: # not has_branch and not has_commit | ||
| error("Must set one of branch, commit_id") |
There was a problem hiding this comment.
Thanks! Turns out we never flake8 this. Opening a new bug to do that, but for now fixed everything flake8 had to complain about. So as punishment PTAL :-/
arielshaqed
added
area/tools
johnnyaug
approved these changes
Jan 1, 2023
|
Thanks muchly! |
arielshaqed
deleted the
bug/4912-lakefs_export-report-errors-not-exceptions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the UX and makes thing more scriptable and more UN*X-like.
Tested by manually running these failing commands:
Fixes #4912.