Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return secondary key for secondary iterator #4945

Merged
merged 1 commit into from
Jan 8, 2023
Merged

Return secondary key for secondary iterator #4945

merged 1 commit into from
Jan 8, 2023

Conversation

guy-har
Copy link
Contributor

@guy-har guy-har commented Jan 8, 2023

No description provided.

@guy-har guy-har requested review from nopcoder and N-o-Z and removed request for nopcoder January 8, 2023 08:48
N-o-Z
N-o-Z requested changes Jan 8, 2023
View reviewed changes
Copy link
Member

@N-o-Z N-o-Z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really sure why is this change required - The secondary iterator iterates using the secondary key but should return the primary value

nopcoder
nopcoder approved these changes Jan 8, 2023
View reviewed changes
Copy link
Contributor

@nopcoder nopcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!!

N-o-Z
N-o-Z approved these changes Jan 8, 2023
View reviewed changes
Copy link
Member

@N-o-Z N-o-Z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - approved!

@guy-har guy-har linked an issue Jan 8, 2023 that may be closed by this pull request
KV - secondary iterator returns wrong key #4948
Closed
@guy-har guy-har added the include-changelog PR description should be included in next release changelog label Jan 8, 2023
@guy-har guy-har merged commit 1e3a2d1 into master Jan 8, 2023
@guy-har guy-har deleted the fix/secondary-key branch January 8, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@N-o-Z N-o-Z N-o-Z approved these changes

@nopcoder nopcoder nopcoder approved these changes

Assignees
No one assigned
Labels
include-changelog PR description should be included in next release changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KV - secondary iterator returns wrong key
3 participants
@guy-har @nopcoder @N-o-Z