Fix Crashing UI on RefDropdown #5043
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itaiad200
added
bug
ozkatz
requested changes
Jan 15, 2023
| @@ -221,7 +221,7 @@ const RefDropdown = ({ repo, selected, selectRef, onCancel, variant="light", pre | |||
| const popover = ( | |||
| <Overlay target={target.current} show={show} placement="bottom" rootClose={true} onHide={() => setShow(false)}> | |||
| <Popover className="ref-popover"> | |||
| <Popover.Body> | |||
| <Popover.Content> | |||
There was a problem hiding this comment.
Popover in v2.7.0 (which is the one we're now using) has a Body property instead of a Content one.
see: https://github.com/react-bootstrap/react-bootstrap/blob/v2.7.0/src/Popover.tsx#L131
I'm guessing your npm dependencies are out of date (npm install or maybe ever delete your existing node_modules)
There was a problem hiding this comment.
additionally, make sure you re-generate the UI (make gen-ui)
There was a problem hiding this comment.
Yeah it worked after deleting node_modules, npm install by itself wasn't enough. Closing, sorry for the noise..
|
For more context: #5034 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5042