-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge API response - remove summary field #5115
Conversation
Does this break existing code? I would prefer to return junk numbers, or an arbitrary map, than do that. If we do decide to break b/c, we will need to communicate to our users. We are one of those users, I think our Airflow provider provides merge. It mustn't break. |
It will break clients with old API like other breaking changes. No existing code in lakeFS uses this response. |
@arielshaqed created #5119 to have a version where the field is optional while the server will return a valid answer until we remove the summary field. |
b67df37
to
a1deb0f
Compare
2db91b0
to
67ed15f
Compare
🎊 PR Preview f37b0a8 has been successfully built and deployed to https://treeverse-lakeFS-preview-pr-5115.surge.sh 🕐 Build time: 0.027s 🤖 By surge-preview |
return "bare" | ||
case sampleData: | ||
ref = "sample" | ||
return "sample" | ||
} | ||
return ref | ||
return "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed the use of ref
as it also a package name in this code
62746d8
to
f37b0a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This remains a very far-reaching change. For instance: say I upgrade my lakeFS. Then my Airflow DAGs stop working! Let's add a note to the CHANGELOG now (could be in the next PR, of course, rather than wait for whoever next releases lakeFS). |
Thanks @arielshaqed!! I'll fix the client version used by Airflow before merging this one and add a note. |
Update lakefs airflow provider treeverse/airflow-provider-lakeFS#66 |
This is API breaking change
Remove merge response summary as we do not reflect the actual numbers.
In case caller would like to have data about the merge, it should be reflected by calling diff after getting the new merge reference.
Close #3978
Users who use lakeFS SDK lower than v0.91.0 and verify the response will not work with this version of lakeFS as we dropped the merge summary.