Email subscription drop rate #5145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eladlachmi
added
the
include-changelog
nopcoder
suggested changes
Jan 31, 2023
pkg/api/controller.go
Outdated
| @@ -3511,9 +3511,13 @@ func (c *Controller) GetSetupState(w http.ResponseWriter, r *http.Request) { | |||
| writeError(w, r, http.StatusInternalServerError, err) | |||
| return | |||
| } | |||
|
|
|||
| if savedState == auth.SetupStateNotInitialized { | |||
| c.Collector.CollectEvent(stats.Event{Class: "global", Name: "preinit", Client: httputil.GetRequestLakeFSClient(r)}) | |||
There was a problem hiding this comment.
This is a new metric you understand how many users are still in preinit state?
The call for GetSetupState is called many names - each login if I remember to understand if we need to redirect the user to the setup flow.
The problem will be that for external API we always in not initialized mode and we will get this event on all checks.
nopcoder
approved these changes
Jan 31, 2023
pkg/api/controller.go
Outdated
| @@ -3511,6 +3511,10 @@ func (c *Controller) GetSetupState(w http.ResponseWriter, r *http.Request) { | |||
| writeError(w, r, http.StatusInternalServerError, err) | |||
| return | |||
| } | |||
|
|
|||
| if !c.Config.IsAuthTypeAPI() && savedState == auth.SetupStateNotInitialized { | |||
There was a problem hiding this comment.
Suggest to merge the two condition into if/else
state := string(savedState)
// no need to create an admin user if users are managed externally
if c.Config.IsAuthTypeAPI() {
state = string(auth.SetupStateInitialized)
} else if savedState == auth.SetupStateNotInitialized {
c.Collector.CollectEvent(stats.Event{Class: "global", Name: "preinit", Client: httputil.GetRequestLakeFSClient(r)})
}
eladlachmi
force-pushed
the
4958-email-drop-rate
branch
from
15a15a7 to
4076dc0
Compare
This was referenced Feb 22, 2023
This was referenced Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4958