Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Warn when no gc rules are defined for long living repos #5400

Merged
merged 4 commits into from
Mar 8, 2023

Conversation

ozkatz
Copy link
Collaborator

@ozkatz ozkatz commented Mar 7, 2023

Closes #5399

Example of a warning:

image

Dismissing the warning is persistent in the browser (for the current repository)

@ozkatz ozkatz added the include-changelog PR description should be included in next release changelog label Mar 7, 2023
@ozkatz ozkatz changed the title Feature/warn no gc rules UI: Warn when no gc rules are defined for long living repos Mar 7, 2023
Copy link
Contributor

@Jonathan-Rosenberg Jonathan-Rosenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

webui/src/pages/repositories/repository/objects.jsx Outdated Show resolved Hide resolved
@@ -32,12 +32,12 @@ export const SettingsLayout = ({ children, activeTab }) => {
</Nav>
<Nav variant="pills" className="flex-column">
<Link component={Nav.Link} href={{pathname: '/repositories/:repoId/settings/retention', params: {repoId }}} active={activeTab === 'retention'}>
Retention
Garbage Collection
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

Co-authored-by: Jonathan Rosenberg <96974219+Jonathan-Rosenberg@users.noreply.github.com>
Copy link
Contributor

@talSofer talSofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ozkatz!!

@ozkatz ozkatz merged commit 653df9b into master Mar 8, 2023
@ozkatz ozkatz deleted the feature/warn-no-gc-rules branch March 8, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include-changelog PR description should be included in next release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI: Warn when a repository has no GC rules configured
3 participants