Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: S3 accept header prefer application/xml #5447

Merged
merged 1 commit into from
Mar 12, 2023
Merged

Fix: S3 accept header prefer application/xml #5447

merged 1 commit into from
Mar 12, 2023

Conversation

nopcoder
Copy link
Contributor

Fix #5441

@nopcoder nopcoder added bug Something isn't working include-changelog PR description should be included in next release changelog labels Mar 12, 2023
@nopcoder nopcoder requested a review from arielshaqed March 12, 2023 08:43
@nopcoder nopcoder self-assigned this Mar 12, 2023
arielshaqed
arielshaqed approved these changes Mar 12, 2023
View reviewed changes
Copy link
Contributor

@arielshaqed arielshaqed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

This is necessary but unfortunately disgusting code to fix S3 clients that manage not to support HTTP. 🤮 So a really good solution in the realm of feasible solutions.

@nopcoder nopcoder merged commit b74814a into master Mar 12, 2023
@nopcoder nopcoder deleted the fix/s3-accept branch March 12, 2023 12:37
nopcoder added a commit that referenced this pull request Mar 20, 2023
@nopcoder
S3 accept header prefer application/xml (#5447)
221844e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arielshaqed arielshaqed arielshaqed approved these changes

Assignees

@nopcoder nopcoder

Labels
bug Something isn't working include-changelog PR description should be included in next release changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lakeFS S3 gateway behaviour when accessed from R
2 participants
@nopcoder @arielshaqed