Fix lakectl table write to non tty non string column #5500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nopcoder
added
bug
arielshaqed
approved these changes
Mar 16, 2023
cmd/lakectl/cmd/common_helpers.go
Outdated
| @@ -151,7 +151,7 @@ func WriteTo(tpl string, data interface{}, w io.Writer) { | |||
| var b strings.Builder | |||
| for _, row := range tab.Rows { | |||
| for ic, cell := range row { | |||
| b.WriteString(fmt.Sprintf("%s", cell)) | |||
| b.WriteString(fmt.Sprintf("%v", cell)) | |||
There was a problem hiding this comment.
Can we use just fmt.Sprint? (Should we, given the danger of format during confusion?)
There was a problem hiding this comment.
I'll split the format and write. The Sprintf will render a single cell value - but in order to concat full table content I'm using strings.Builder.
The non-tty is related to the fact that we use this code while render the table when we identify that the output is not the terminal. |
nopcoder
added a commit
that referenced
this pull request
Mar 20, 2023
* Fix lakectl table write to non tty non string column * split cell fmt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5433