Delta Lake: Update Dockerfile base images to Alpine #5546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jonathan-Rosenberg
added
exclude-changelog
Jonathan-Rosenberg
requested review from
nopcoder,
johnnyaug,
arielshaqed and
itaiad200
arielshaqed
approved these changes
Mar 21, 2023
| @@ -36,34 +36,33 @@ COPY ./pkg/plugins/diff/delta_diff_server/Cargo.lock ./Cargo.lock | |||
| COPY ./pkg/plugins/diff/delta_diff_server/Cargo.toml ./Cargo.toml | |||
|
|
|||
| # 3. Build only the dependencies to cache them in this layer | |||
| RUN cargo build --release | |||
| RUN RUSTFLAGS=-Ctarget-feature=-crt-static cargo build --release | |||
There was a problem hiding this comment.
This flag is worth documenting (based on F2F explanations), perhaps by adding a link that explains something about why we need it.
| RUN apt-get update | ||
| RUN apt-get install -o APT::Keep-Downloaded-Packages=false -y ca-certificates | ||
| FROM --platform=$BUILDPLATFORM alpine:3.16.0 AS lakectl | ||
| RUN apk add -U --no-cache ca-certificates |
There was a problem hiding this comment.
Not sure how this (and similar) lines should work: Docker itself keeps a cache, and will only re-run this line if it or some line above it changes.
johnnyaug
approved these changes
Mar 21, 2023
Jonathan-Rosenberg
added a commit
that referenced
this pull request
Mar 22, 2023
* fix hover issue when hovering over a tree-entry-row * enable Delta Lake diff feature * remove experimental delta diff button * PR fixes * change docker image publish target to lakefs-plugins * fix bug hunt bugs (#5534) * remove empty line * Delta Lake: Update Dockerfile base images to Alpine (#5546) * change the Dockerfile back to Alpine and build the Delta plugin dynamically * remove alpine-sdk from dockerfile * add alpine-sdk * add comment about the 'RUSTFLAGS=-Ctarget-feature=-crt-static' flag * change back from bullseye to alpine
Jonathan-Rosenberg
added a commit
that referenced
this pull request
Mar 22, 2023
* Display images in markdown with support for lakefs:// URIs (#5449) * Display images in markdown with support for lakefs:// URIs * change dockerfile to include delta diff * change Dockerfile to include the Delta Lake diff plugin * fix docker-compose files * add a stage with both lakefs and plugins and separate it from a lakefs-only stage * PR fixes * Delta Lake Diff: Enable feature (#5508) * fix hover issue when hovering over a tree-entry-row * enable Delta Lake diff feature * remove experimental delta diff button * PR fixes * change docker image publish target to lakefs-plugins * fix bug hunt bugs (#5534) * remove empty line * Delta Lake: Update Dockerfile base images to Alpine (#5546) * change the Dockerfile back to Alpine and build the Delta plugin dynamically * remove alpine-sdk from dockerfile * add alpine-sdk * add comment about the 'RUSTFLAGS=-Ctarget-feature=-crt-static' flag * change back from bullseye to alpine --------- Co-authored-by: eladlachmi <110764839+eladlachmi@users.noreply.github.com>
Jonathan-Rosenberg
added a commit
that referenced
this pull request
Mar 22, 2023
* change default behavior of plugin loading to scan in the default plugins directory for known plugins * get delta lake diff plugin from default path if available * add homedir.Expand call to custom plugin path * remove empty line Co-authored-by: Barak Amar <barak.amar@treeverse.io> * change version from a pointer to an int * Delta Lake Diff: Dockerfile (#5496) * Display images in markdown with support for lakefs:// URIs (#5449) * Display images in markdown with support for lakefs:// URIs * change dockerfile to include delta diff * change Dockerfile to include the Delta Lake diff plugin * fix docker-compose files * add a stage with both lakefs and plugins and separate it from a lakefs-only stage * PR fixes * Delta Lake Diff: Enable feature (#5508) * fix hover issue when hovering over a tree-entry-row * enable Delta Lake diff feature * remove experimental delta diff button * PR fixes * change docker image publish target to lakefs-plugins * fix bug hunt bugs (#5534) * remove empty line * Delta Lake: Update Dockerfile base images to Alpine (#5546) * change the Dockerfile back to Alpine and build the Delta plugin dynamically * remove alpine-sdk from dockerfile * add alpine-sdk * add comment about the 'RUSTFLAGS=-Ctarget-feature=-crt-static' flag * change back from bullseye to alpine --------- Co-authored-by: eladlachmi <110764839+eladlachmi@users.noreply.github.com> --------- Co-authored-by: Barak Amar <barak.amar@treeverse.io> Co-authored-by: eladlachmi <110764839+eladlachmi@users.noreply.github.com>
Jonathan-Rosenberg
added a commit
that referenced
this pull request
Mar 22, 2023
* add makefile target to build delta diff plugin * test goreleaser with rust * remove cache step * add activate on push to this branch * change working-directory * remove working-directory * remove target from args * add protoc for mac and name steps * add version to protoc action * switch from Arduino * use correct version * change back to arduino * change version to 3.x * add protoc to unix and windows * change version to 3.x * change to release, upload artifact * downloading artifacts * add needs to releaser * add build * move --release to arguments * fix artifact location * fix naming * add cache * add .exe suffix to windows build target * add id to the download artifact step * add registry and index to cache * add renaming of artifacts * move download-artifacts to the goreleaser job * change cache support to use custom action * run goreleaser without truly releasing * fix goreleaser * change delta artifact location * fix releaser yaml * change releaser to be production ready * change from 3 jobs definitions to a single job definition with a more complex matrix * fix makefile * Delta Lake Diff: Change default plugin loading (#5495) * change default behavior of plugin loading to scan in the default plugins directory for known plugins * get delta lake diff plugin from default path if available * add homedir.Expand call to custom plugin path * remove empty line Co-authored-by: Barak Amar <barak.amar@treeverse.io> * change version from a pointer to an int * Delta Lake Diff: Dockerfile (#5496) * Display images in markdown with support for lakefs:// URIs (#5449) * Display images in markdown with support for lakefs:// URIs * change dockerfile to include delta diff * change Dockerfile to include the Delta Lake diff plugin * fix docker-compose files * add a stage with both lakefs and plugins and separate it from a lakefs-only stage * PR fixes * Delta Lake Diff: Enable feature (#5508) * fix hover issue when hovering over a tree-entry-row * enable Delta Lake diff feature * remove experimental delta diff button * PR fixes * change docker image publish target to lakefs-plugins * fix bug hunt bugs (#5534) * remove empty line * Delta Lake: Update Dockerfile base images to Alpine (#5546) * change the Dockerfile back to Alpine and build the Delta plugin dynamically * remove alpine-sdk from dockerfile * add alpine-sdk * add comment about the 'RUSTFLAGS=-Ctarget-feature=-crt-static' flag * change back from bullseye to alpine --------- Co-authored-by: eladlachmi <110764839+eladlachmi@users.noreply.github.com> --------- Co-authored-by: Barak Amar <barak.amar@treeverse.io> Co-authored-by: eladlachmi <110764839+eladlachmi@users.noreply.github.com> --------- Co-authored-by: Barak Amar <barak.amar@treeverse.io> Co-authored-by: eladlachmi <110764839+eladlachmi@users.noreply.github.com>
nopcoder
added a commit
that referenced
this pull request
Apr 17, 2023
* add makefile target to build delta diff plugin * test goreleaser with rust * remove cache step * add activate on push to this branch * change working-directory * remove working-directory * remove target from args * add protoc for mac and name steps * add version to protoc action * switch from Arduino * use correct version * change back to arduino * change version to 3.x * add protoc to unix and windows * change version to 3.x * change to release, upload artifact * downloading artifacts * add needs to releaser * add build * move --release to arguments * fix artifact location * fix naming * add cache * add .exe suffix to windows build target * add id to the download artifact step * add registry and index to cache * add renaming of artifacts * move download-artifacts to the goreleaser job * change cache support to use custom action * run goreleaser without truly releasing * fix goreleaser * change delta artifact location * fix releaser yaml * change releaser to be production ready * change from 3 jobs definitions to a single job definition with a more complex matrix * fix makefile * Delta Lake Diff: Change default plugin loading (#5495) * change default behavior of plugin loading to scan in the default plugins directory for known plugins * get delta lake diff plugin from default path if available * add homedir.Expand call to custom plugin path * remove empty line Co-authored-by: Barak Amar <barak.amar@treeverse.io> * change version from a pointer to an int * Delta Lake Diff: Dockerfile (#5496) * Display images in markdown with support for lakefs:// URIs (#5449) * Display images in markdown with support for lakefs:// URIs * change dockerfile to include delta diff * change Dockerfile to include the Delta Lake diff plugin * fix docker-compose files * add a stage with both lakefs and plugins and separate it from a lakefs-only stage * PR fixes * Delta Lake Diff: Enable feature (#5508) * fix hover issue when hovering over a tree-entry-row * enable Delta Lake diff feature * remove experimental delta diff button * PR fixes * change docker image publish target to lakefs-plugins * fix bug hunt bugs (#5534) * remove empty line * Delta Lake: Update Dockerfile base images to Alpine (#5546) * change the Dockerfile back to Alpine and build the Delta plugin dynamically * remove alpine-sdk from dockerfile * add alpine-sdk * add comment about the 'RUSTFLAGS=-Ctarget-feature=-crt-static' flag * change back from bullseye to alpine --------- Co-authored-by: eladlachmi <110764839+eladlachmi@users.noreply.github.com> --------- Co-authored-by: Barak Amar <barak.amar@treeverse.io> Co-authored-by: eladlachmi <110764839+eladlachmi@users.noreply.github.com> --------- Co-authored-by: Barak Amar <barak.amar@treeverse.io> Co-authored-by: eladlachmi <110764839+eladlachmi@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.