Ranges cache: add ownership check #6004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No linked issues found. Please add the corresponding issues in the pull request description. |
Jonathan-Rosenberg
added
the
exclude-changelog
Jonathan-Rosenberg
added
the
minor-change
arielshaqed
approved these changes
Jun 2, 2023
| @@ -92,7 +92,13 @@ func (m *RangeManager) GetValueGE(ctx context.Context, ns committed.Namespace, i | |||
| } | |||
| return nil, ErrKeyNotFound | |||
| } | |||
| vBytes, _, err := value.Value(nil) | |||
| vBytes, owned, err := value.Value(nil) | |||
| if !owned { | |||
There was a problem hiding this comment.
Wow, great catch!
Is there any way for us to change this bad ownership status? IIUC when !owned, iterator it shares underlying state with some other iterator. I would expect this state to persist, and now very many calls (including future getValue()s) will keep on copying every value. It might be considerably more efficient if we could convince Pebble to unshare the iterator -- say by creating future iterators on a new iterator hierarchy. (It goes without saying that this is no reason to delay this PR!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we pass
nilwhen calling forValue, the initialized buffer isn't owned by the calling function. This makes the behavior of the data inside the buffer unexpected. You can read about it here some more ([P1], [P2]).Closes 1578