Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix create and delete branch protection error and lakectl output #6135

Merged
merged 3 commits into from
Jun 26, 2023

Conversation

nopcoder
Copy link
Contributor

@nopcoder nopcoder commented Jun 22, 2023

  • API returns 409 conflict on existing rule
  • API returns 404 not found on missing rule
  • lakectl message on add or delete rule

Fix #5548
Fix #6138

- API returns 409 conflict on existing rule
- API returns 404 not found on missing rule
- lakectl message on add or delete rule
@nopcoder nopcoder added bug Something isn't working area/API Improvements or additions to the API labels Jun 22, 2023
@nopcoder nopcoder requested a review from johnnyaug June 22, 2023 12:51
@nopcoder nopcoder self-assigned this Jun 22, 2023
@github-actions
Copy link

github-actions bot commented Jun 22, 2023

🎊 PR Preview 66df345 has been successfully built and deployed to https://treeverse-lakeFS-preview-pr-6135.surge.sh

🕐 Build time: 0.014s

🤖 By surge-preview

@nopcoder nopcoder added the include-changelog PR description should be included in next release changelog label Jun 22, 2023
@nopcoder nopcoder requested a review from itaiad200 June 26, 2023 08:54
cmd/lakectl/cmd/branch_protect.go Outdated Show resolved Hide resolved
Co-authored-by: Yoni <yoni.augarten@treeverse.io>
@nopcoder nopcoder enabled auto-merge (squash) June 26, 2023 13:53
@nopcoder nopcoder merged commit 112e082 into master Jun 26, 2023
@nopcoder nopcoder deleted the fix/branch-protect branch June 26, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/API Improvements or additions to the API bug Something isn't working include-changelog PR description should be included in next release changelog
Projects
None yet
2 participants