Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop publishing lakeFS DuckDB image #6141

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

rmoff
Copy link
Contributor

@rmoff rmoff commented Jun 26, 2023

Linked Issue

Closes #6001


Change Description

Background

We publish a Docker image that includes DuckDB. The quickstart has now been changed (#6092) and therefore we can remove the DuckDB Docker image.

Testing Details

How were the changes tested? they weren't, I'm assuming that the changes to the build files are correct

Notes

Should we also prune the *duckdb images from Docker Hub?

@rmoff rmoff linked an issue Jun 26, 2023 that may be closed by this pull request
@rmoff rmoff added include-changelog PR description should be included in next release changelog minor-change Used for PRs that don't require issue attached labels Jun 26, 2023
@rmoff
Copy link
Contributor Author

rmoff commented Jun 26, 2023

Do not merge until #6092 is merged

@rmoff rmoff requested a review from arielshaqed June 26, 2023 11:06
Copy link
Contributor

@arielshaqed arielshaqed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:-)

@rmoff rmoff marked this pull request as ready for review June 26, 2023 12:05
@rmoff rmoff merged commit 6c99427 into master Jun 26, 2023
@rmoff rmoff deleted the 6001-remove-duckdb-from-lakefs-docker-image branch June 26, 2023 12:05
@rmoff
Copy link
Contributor Author

rmoff commented Jun 26, 2023

@arielshaqed Should we also prune the *duckdb images from Docker Hub? If so who has creds to do this? thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include-changelog PR description should be included in next release changelog minor-change Used for PRs that don't require issue attached
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove DuckDB from lakeFS Docker image
2 participants