Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: allow loading >10k diff summary #6287

Merged
merged 1 commit into from
Jul 31, 2023
Merged

UI: allow loading >10k diff summary #6287

merged 1 commit into from
Jul 31, 2023

Conversation

ozkatz
Copy link
Collaborator

@ozkatz ozkatz commented Jul 31, 2023

Allow UI to load big summaries. Currently the UI returns an error when trying to summarize a diff bigger than 10,000 objects. This lets the user decide if they would like to pull all changes anyway.

Before:

before

After:

after

@ozkatz ozkatz added area/UI Improvements or additions to UI include-changelog PR description should be included in next release changelog minor-change Used for PRs that don't require issue attached labels Jul 31, 2023
@ozkatz ozkatz requested review from johnnyaug and eladlachmi July 31, 2023 09:33
@ozkatz ozkatz self-assigned this Jul 31, 2023
@ozkatz ozkatz requested a review from idanovo July 31, 2023 14:20
idanovo
idanovo approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@idanovo idanovo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ozkatz ozkatz merged commit a26609e into master Jul 31, 2023
@ozkatz ozkatz deleted the ui/load-all-summary branch July 31, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idanovo idanovo idanovo approved these changes

@johnnyaug johnnyaug Awaiting requested review from johnnyaug

@eladlachmi eladlachmi Awaiting requested review from eladlachmi

Assignees

@ozkatz ozkatz

Labels
area/UI Improvements or additions to UI include-changelog PR description should be included in next release changelog minor-change Used for PRs that don't require issue attached
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ozkatz @idanovo