Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated node-forge to fix CVE-2020-7720 #637

Merged
merged 1 commit into from
Sep 22, 2020
Merged

updated node-forge to fix CVE-2020-7720 #637

merged 1 commit into from
Sep 22, 2020

Conversation

ozkatz
Copy link
Collaborator

@ozkatz ozkatz commented Sep 22, 2020

closes #636

@ozkatz ozkatz added pr/javascript Pull requests that update Javascript code area/UI Improvements or additions to UI security labels Sep 22, 2020
@ozkatz ozkatz requested a review from arielshaqed September 22, 2020 13:11
@ozkatz
Copy link
Collaborator Author

ozkatz commented Sep 22, 2020

important to note that we're not actually using node-forge directly or indirectly. This is a dependency pulled in by react-scripts.

arielshaqed
arielshaqed approved these changes Sep 22, 2020
View reviewed changes
Copy link
Contributor

@arielshaqed arielshaqed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it works it's good (in the sense that it's better than the unfixed one).

@ozkatz ozkatz merged commit eb57df4 into master Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arielshaqed arielshaqed arielshaqed approved these changes

Assignees
No one assigned
Labels
area/UI Improvements or additions to UI pr/javascript Pull requests that update Javascript code security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix CVE-2020-7720
2 participants
@ozkatz @arielshaqed