change compose execution in quickstart and README #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ozkatz
added
the
pr/merge-if-approved
nopcoder
reviewed
Sep 24, 2020
README.md
Outdated
|
|
||
| 1. Ensure you have Docker installed on your computer. The MacOS and Windows installations include Docker Compose by default. | ||
| 1. Ensure you have Docker & docker-compose installed on your computer |
There was a problem hiding this comment.
you have the same line later, "Ensure you have Docker & Docker Compose installed on your computer."
need to be consistent of how to call docker compose and if we use a period in the end.
nopcoder
approved these changes
Sep 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the quickstart guide and the README to use compose.lakefs.io - this eliminates the step of cloning the repo and makes our quickstart essentially a 1-liner.