Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: move specific api to internal tag #6582

Merged
merged 1 commit into from
Sep 12, 2023
Merged

api: move specific api to internal tag #6582

merged 1 commit into from
Sep 12, 2023

Conversation

nopcoder
Copy link
Contributor

Close #6533
Close #6539

Moving the following API operations to internal tag:

  1. setupCommPrefs
  2. setup
  3. getSetupState
  4. getAuthCapabilities
  5. updateBranchToken
  6. uploadObjectPreflight
  7. setGarbageCollectionRulesPreflight
  8. createBranchProtectionRulePreflight
  9. postStatsEvents

@nopcoder nopcoder added the include-changelog PR description should be included in next release changelog label Sep 11, 2023
@nopcoder nopcoder requested a review from itaiad200 September 11, 2023 12:32
@nopcoder nopcoder self-assigned this Sep 11, 2023
@github-actions
Copy link

github-actions bot commented Sep 11, 2023 •
edited
Loading

♻️ PR Preview 897a063 has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@nopcoder nopcoder requested review from arielshaqed and Jonathan-Rosenberg and removed request for itaiad200 September 11, 2023 17:52
arielshaqed
arielshaqed approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@arielshaqed arielshaqed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good but also somewhat nasty...

  1. By tagging something as "internal", we lose the information about whether it was "statistics" or "objects" or "repositories".
  2. If you don't go through a generated API, this PR changes nothing. For instance our webui stays the same in this PR.

We should reconsider whether to change the paths, instead or in addition, and perhaps just tag these REST calls somehow.

@nopcoder
Copy link
Contributor Author

Think it is a good first step as the generated API code will not see the call and while moving to the new client sdk will not access these calls.

@nopcoder nopcoder merged commit e9a809b into master Sep 12, 2023
@nopcoder nopcoder deleted the chore/internal branch September 12, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arielshaqed arielshaqed arielshaqed approved these changes

@Jonathan-Rosenberg Jonathan-Rosenberg Awaiting requested review from Jonathan-Rosenberg

Assignees

@nopcoder nopcoder

Labels
include-changelog PR description should be included in next release changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API cleanup: mark for internal use API cleanup: mark deprecation and move to internal use
2 participants
@nopcoder @arielshaqed