Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

load embedded files dynamicly #6592

Merged
merged 1 commit into from
Sep 13, 2023
Merged

load embedded files dynamicly #6592

merged 1 commit into from
Sep 13, 2023

Conversation

nopcoder
Copy link
Contributor

No description provided.

@nopcoder nopcoder self-assigned this Sep 13, 2023
@github-actions
Copy link

No linked issues found. Please add the corresponding issues in the pull request description.
Use GitHub automation to close the issue when a PR is merged

Isan-Rivkin
Isan-Rivkin approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@Isan-Rivkin Isan-Rivkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested and it works!
I changed the require from catalog_export to catalogexport for the rest of the lua scripts and works as expected!
Thanks!

@Isan-Rivkin Isan-Rivkin merged commit 8755a70 into 6573-table-extractor Sep 13, 2023
27 of 29 checks passed
@Isan-Rivkin Isan-Rivkin deleted the 6573-table-extractor-loader branch September 13, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Isan-Rivkin Isan-Rivkin Isan-Rivkin approved these changes

Assignees

@nopcoder nopcoder

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nopcoder @Isan-Rivkin