-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix azure pre-signed url for blob from different account #6594
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, thanks! I know very little about our Azure internals, @guy-har probably best look at that when he gets back. I am concerned that "adls" doesn't appear in this PR. So instead I'll just ask...
How was this tested?
Manual test and pending @lynnro314 test and verification for the specific data that the bug was found. In order to reproduce you need to use azure and import data from different account. The implementation have two implementation to handle (different API with Azure SDK):
In the first one the API returns the URL after we provide the account/container. This fix make sure we format the object location based azure default endpoint. We should verify that the import works with the blob endpoint also for adls container and remove the support of import from this endpoint. So import with blob domain should work, and this fix should help existing data. |
@lynnro314 ping or merge after verification on your environment. |
Fix #6595