lakectl endpoint configure and endpoint path reuse #6609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
♻️ PR Preview 9d0f6ff has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
nopcoder
added
area/lakectl
nopcoder
force-pushed
the
chore/lakectl-endpoint
branch
from
8b1fea7 to
9425aa6
Compare
cmd/lakectl/cmd/config.go
Outdated
| return err | ||
| } | ||
| if u.Path != "" { | ||
| return fmt.Errorf("%w: do not specify endpoint path", ErrInvalidEndpoint) |
There was a problem hiding this comment.
I think that it shouldn't return an error but instead add a guidance that instructs the user to provide the server's root endpoint: Root sever endpoint URL or something of this sort
Jonathan-Rosenberg
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #6542